-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api_gateway]Add connection query API #822
Conversation
테스트 케이스 작성해보겠습니다 :0 |
api_gateway/connection_query_api.go
Outdated
} | ||
|
||
func (cr *ConnectionRepository) CreateConnection(connCreated event.ConnectionCreated) error { | ||
cr.mux.Lock() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
create보다는 Save(connCreated event.ConnectionCreated) error로 수정해주세요!!
생성이 아니라 connection을 저장하기 때문에 save라는 이름이 좋을 것 같습니다.
api_gateway/connection_query_api.go
Outdated
|
||
_, exist := cr.ConnectionTable[connCreated.ConnectionId] | ||
|
||
if exist { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
40,42번째 두 라인 붙여주세요!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아.. 또 깜빡했네요!
api_gateway/connection_query_api.go
Outdated
return nil | ||
} | ||
|
||
func (cr *ConnectionRepository) CloseConnection(connClosed event.ConnectionClosed) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
함수이름을 close보다 delete or remove로 해주세요!! 다른 파일들참조해서 이름을 맞춰주세요!!
574eb60
to
42cad49
Compare
travis는 왜 통과가 안될까요..흑.. |
p2p/infra/adapter/event_handler.go:78:47: event.ConnectionId undefined (type event.ConnectionClosed has no field or method ConnectionId, but does have ConnectionID) connectionId 부분에서 오류가 나네요! 아마 ConnectionID로 통일하시는 부분에서 일부분 수정이 안된게아닐까 싶습니다! |
컴파일만해보고 런타임은 확인 못했네요 ㅜㅜ 수정하겠습니다..! |
308e17d
to
55ed1cf
Compare
큰 문제가 하나있습니다!!... 제가 제대로 못 알려드렸는데
그리고
이러식으로 수정 부탁드립니다! |
0d6c0aa
to
69139c5
Compare
Issue
#820
Component
api_gateway
Descriptions
add codes for connection query API that can helps users know connection state with peers.